Increase upstream response caching #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only harm in this being high is cache size, because we still send a new request and check for 304, etc.
Allows us to show stale results when we hit rate limits, or when upstream servers are down.
use cached responses if available, without checking for updates
instead of expiring them. Let the cache prune itself.
it's a bit harder than it looks because the client doesn't have a handle on the parent request
minrk
changed the title
the rate limit will be 0 for the last successful request with status 200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce load impact of bots on load by always using a cached response if there is one.saving this for a later PR, since it's not as simple as I thought to tell what incoming request an outgoing request is on behalf of.